[java-opensaml COMMIT] in /trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml: saml1/binding/encoding/HTTPPostE...

[noreply at shibboleth.net]

Author: putmanb
Date: Wed Jan 30 19:06:43 2013
New Revision: 3189

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3189&view=rev
Log:
Encoders won't do SAML XML Signature signing.

Modified:
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPPostEncoder.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPSOAP11Encoder.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/BaseSAML2MessageEncoder.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPPostEncoder.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPPostSimpleSignEncoder.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPSOAP11Encoder.java

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPPostEncoder.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPPostEncoder.java?rev=3189&r1=3188&r2=3189&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPPostEncoder.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPPostEncoder.java Wed Jan 30 19:06:43 2013
@@ -143,9 +143,6 @@
             ((ResponseAbstractType) outboundMessage).setRecipient(endpointURL);
         }
         
-        //TODO decide on this
-        signMessage(messageContext);
-
         postEncode(messageContext, endpointURL);
     }
 

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPSOAP11Encoder.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPSOAP11Encoder.java?rev=3189&r1=3188&r2=3189&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPSOAP11Encoder.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/binding/encoding/HTTPSOAP11Encoder.java Wed Jan 30 19:06:43 2013
@@ -90,9 +90,6 @@
             throw new MessageEncodingException("No outbound SAML message contained in message context");
         }
 
-        //TODO decide on this
-        signMessage(messageContext);
-        
         Envelope envelope = buildSOAPMessage(samlMessage);
         storeSOAPEnvelope(envelope);
     }

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/BaseSAML2MessageEncoder.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/BaseSAML2MessageEncoder.java?rev=3189&r1=3188&r2=3189&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/BaseSAML2MessageEncoder.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/BaseSAML2MessageEncoder.java Wed Jan 30 19:06:43 2013
@@ -49,7 +49,6 @@
 import org.slf4j.LoggerFactory;
 
 //TODO pull allowed URL scheme check out in to a separate class
-//TODO not sure if message signing should be in here either, it's not really part of the encoding process
 
 /**
  * Base class for SAML 2 message encoders.

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPPostEncoder.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPPostEncoder.java?rev=3189&r1=3188&r2=3189&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPPostEncoder.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPPostEncoder.java Wed Jan 30 19:06:43 2013
@@ -143,9 +143,6 @@
         String endpointURL = getEndpointURL(messageContext).toString();
         setResponseDestination(outboundMessage, endpointURL);
 
-        //TODO decide on this
-        signMessage(messageContext);
-
         postEncode(messageContext, endpointURL);
     }
 

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPPostSimpleSignEncoder.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPPostSimpleSignEncoder.java?rev=3189&r1=3188&r2=3189&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPPostSimpleSignEncoder.java (original)

[... 72 lines stripped ...]