[java-opensaml COMMIT] /trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPRedirectD...

[noreply at shibboleth.net]

Author: putmanb
Date: Fri Jan 25 18:09:25 2013
New Revision: 3168

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3168&view=rev
Log:
OSJ-34, fixing an original and undetected java-support refactoring bug from a long time ago.  No query params were being emitted in the unsigned case.

Modified:
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPRedirectDeflateEncoder.java

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPRedirectDeflateEncoder.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPRedirectDeflateEncoder.java?rev=3168&r1=3167&r2=3168&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPRedirectDeflateEncoder.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/encoding/HTTPRedirectDeflateEncoder.java Fri Jan 25 18:09:25 2013
@@ -22,6 +22,7 @@
 import java.io.UnsupportedEncodingException;
 import java.net.URI;
 import java.net.URISyntaxException;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.zip.Deflater;
 import java.util.zip.DeflaterOutputStream;
@@ -169,8 +170,7 @@
             throw new MessageEncodingException("Endpoint URL " + endpoint + " is not a valid URL", e);
         }
 
-        List<Pair<String, String>> queryParams = UriSupport.parseQueryString(endpointUrl.getQuery());
-        queryParams.clear();
+        List<Pair<String, String>> queryParams = new ArrayList<Pair<String,String>>();
         
         SAMLObject outboundMessage = messageContext.getMessage();
 
@@ -198,8 +198,9 @@
 
             queryParams.add(new Pair<String, String>("Signature", generateSignature(signingCredential, sigAlgURI,
                     sigMaterial)));
-            endpointUrl = UriSupport.setQuery(endpointUrl, queryParams);
-        }
+        }
+        
+        endpointUrl = UriSupport.setQuery(endpointUrl, queryParams);
 
         return endpointUrl.toASCIIString();
     }