[java-opensaml COMMIT] /trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageH...

noreply at shibboleth.net noreply at shibboleth.net
Mon Jan 14 19:40:45 EST 2013


Author: scantor
Date: Mon Jan 14 19:40:45 2013
New Revision: 3143

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3143&view=rev
Log:
Filter iteration of handlers.

Modified:
    trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java

Modified: trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java?rev=3143&r1=3142&r2=3143&view=diff
==============================================================================
--- trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java (original)
+++ trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java Mon Jan 14 19:40:45 2013
@@ -28,6 +28,9 @@
 import org.opensaml.messaging.handler.MessageHandler;
 import org.opensaml.messaging.handler.MessageHandlerChain;
 import org.opensaml.messaging.handler.MessageHandlerException;
+
+import com.google.common.base.Predicates;
+import com.google.common.collect.Iterables;
 
 /**
  * A basic implementation of {@link MessageHandlerChain}.
@@ -76,10 +79,8 @@
     /** {@inheritDoc} */
     public void doInvoke(@Nonnull final MessageContext<MessageType> msgContext) throws MessageHandlerException {
         if (members != null) {
-            for (MessageHandler handler: members) {
-                if (handler != null) {
-                    handler.invoke(msgContext);
-                }
+            for (MessageHandler handler: Iterables.filter(members, Predicates.notNull())) {
+                handler.invoke(msgContext);
             }
         }
     }



More information about the commits mailing list