[java-identity-provider COMMIT] in /trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/reso...

[noreply at shibboleth.net]

Author: rdw
Date: Thu Feb 14 14:52:12 2013
New Revision: 4281

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4281&view=rev
Log:
Expand some TODO.

Modified:
    trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML1NameIdentifierAttributeDefinition.java
    trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML2NameIDAttributeDefinition.java
    trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/TransientIdAttributeDefinition.java
    trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/dc/BaseComputedIDDataConnector.java
    trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/dc/StoredIDDataConnector.java

Modified: trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML1NameIdentifierAttributeDefinition.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML1NameIdentifierAttributeDefinition.java?rev=4281&r1=4280&r2=4281&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML1NameIdentifierAttributeDefinition.java (original)
+++ trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML1NameIdentifierAttributeDefinition.java Thu Feb 14 14:52:12 2013
@@ -70,6 +70,10 @@
 
     /** Strategy used to locate the IdP EntityId given a {@link AttributeResolutionContext}. */
     // TODO(rdw) These needs to be changed when the profile handling has been finalized
+    // TODO Do we mean IdP or RelyingParty or what? Fix when [...]
+    // the questions in https://wiki.shibboleth.net/confluence/display/OS30/Messaging+Abstractions+Discussion+Document
+    // are answered
+    // TODO should this be a org.opensaml.messaging.context.navigate.ContextDataLookupFunction ?
     private Function<AttributeResolutionContext, String> idPEntityIdStrategy;
 
     /**

Modified: trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML2NameIDAttributeDefinition.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML2NameIDAttributeDefinition.java?rev=4281&r1=4280&r2=4281&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML2NameIDAttributeDefinition.java (original)
+++ trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/SAML2NameIDAttributeDefinition.java Thu Feb 14 14:52:12 2013
@@ -72,10 +72,18 @@
 
     /** Strategy used to locate the RelyingParty EntityId given a {@link AttributeResolutionContext}. */
     // TODO(rdw) These needs to be changed when the profile handling has been finalized
+    // TODO Do we mean IdP or RelyingParty or what? Fix when [...]
+    // the questions in https://wiki.shibboleth.net/confluence/display/OS30/Messaging+Abstractions+Discussion+Document
+    // are answered
+    // TODO should this be a org.opensaml.messaging.context.navigate.ContextDataLookupFunction ?
     private Function<AttributeResolutionContext, String> spEntityIdStrategy;
 
     /** Strategy used to locate the IdP EntityId given a {@link AttributeResolutionContext}. */
     // TODO(rdw) These needs to be changed when the profile handling has been finalized
+    // TODO Do we mean IdP or RelyingParty or what? Fix when [...]
+    // the questions in https://wiki.shibboleth.net/confluence/display/OS30/Messaging+Abstractions+Discussion+Document
+    // are answered
+    // TODO should this be a org.opensaml.messaging.context.navigate.ContextDataLookupFunction ?
     private Function<AttributeResolutionContext, String> idPEntityIdStrategy;
 
     /**

Modified: trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/TransientIdAttributeDefinition.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/TransientIdAttributeDefinition.java?rev=4281&r1=4280&r2=4281&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/TransientIdAttributeDefinition.java (original)
+++ trunk/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/impl/ad/TransientIdAttributeDefinition.java Thu Feb 14 14:52:12 2013
@@ -68,14 +68,18 @@
 
     /** Strategy used to locate the IdP EntityId given a {@link AttributeResolutionContext}. */

[... 54 lines stripped ...]