[java-identity-provider COMMIT] in /trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resol...

[noreply at shibboleth.net]

Author: rdw
Date: Wed Aug 14 09:07:04 2013
New Revision: 4687

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4687&view=rev
Log:
IDP-273 Cleanup- javadoc/annotation/...

Modified:
    trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AttributeRecipientContext.java
    trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseDataConnector.java
    trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java
    trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/PluginDependencySupport.java
    trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/PrincipalConnectorDefinition.java
    trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/ResolverPluginDependency.java

Modified: trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AttributeRecipientContext.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AttributeRecipientContext.java?rev=4687&r1=4686&r2=4687&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AttributeRecipientContext.java (original)
+++ trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AttributeRecipientContext.java Wed Aug 14 09:07:04 2013
@@ -24,18 +24,23 @@
 import org.opensaml.saml.saml2.metadata.EntityDescriptor;
 import org.opensaml.saml.saml2.metadata.RoleDescriptor;
 
-/** A context which carries Information about the Recipient of the attribute.  This is the
- *  principal, the "self" entityID and the RecipientEntityID. */
+/** A context which carries Information about the recipient of the attribute.  This is the
+ *  principal, the "self" entityID and the RecipientEntityID.
+ *  <br/>TODO
+ *  This context is here mostly as a temporary scaffolding to allow development of the 
+ *  attribute filter and resolver.  We expect it to change.
+ *   
+ *   */
 @NotThreadSafe
 public class AttributeRecipientContext extends BaseContext {
 
-    /** The unique principal. This is required by some resolvers and injected during setup. */
+    /** The unique principal. This is required by some resolvers and filters and injected during setup. */
     private String principal;
     
-    /** The local entityID. This is required by some resolvers and injected during setup. */
+    /** The local entityID. This is required by some resolvers and filters and injected during setup. */
     private String attributeIssuerID;
     
-    /** The other entityID. This is required by some resolvers and injected during setup. */
+    /** The other entityID. This is required by some resolvers and filters and injected during setup. */
     private String attributeRecipientID;
     
     /** How was the principal Authenticated? */

Modified: trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseDataConnector.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseDataConnector.java?rev=4687&r1=4686&r2=4687&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseDataConnector.java (original)
+++ trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseDataConnector.java Wed Aug 14 09:07:04 2013
@@ -117,7 +117,7 @@
             @Nonnull final AttributeResolutionContext resolutionContext) throws ResolutionException;
     
     /**
-     * return a string which is to be prepended to all log messages.
+     * Return a string which is to be prepended to all log messages.
      * 
      * @return "Data connector '<definitionID>' :"
      */

Modified: trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java?rev=4687&r1=4686&r2=4687&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java (original)
+++ trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java Wed Aug 14 09:07:04 2013
@@ -23,6 +23,7 @@
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
+import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;

[... 262 lines stripped ...]