[JIRA] Commented: (JOST-195) Use system property-based override for our custom ESAPI config rather than ESAPI locator class call

Brent Putman (JIRA) noreply at shibboleth.net
Fri Sep 14 18:37:21 EDT 2012


    [ https://issues.shibboleth.net/jira/browse/JOST-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392#comment-14392 ] 

Brent Putman commented on JOST-195:
-----------------------------------

Implemented in r1590.

Turns out for the case that the system property isn't set and we want to wire in the OpenSAML internal config, we still need to call ESAPI.initialize().  The system property is only evaled and stored once, in a static initializer, so if something had already loaded the class, setting the system property in DefaultBootstrap won't do anything.

> Use system property-based override for our custom ESAPI config rather than ESAPI locator class call 
> ----------------------------------------------------------------------------------------------------
>
>                 Key: JOST-195
>                 URL: https://issues.shibboleth.net/jira/browse/JOST-195
>             Project: OpenSAML 2 - Java
>          Issue Type: Improvement
>    Affects Versions: 2.5.3
>            Reporter: Brent Putman
>            Assignee: Brent Putman
>            Priority: Minor
>             Fix For: 2.5.4
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> The current approach is to call ESAPI.initialize(implClassName).
> This will allow calling code that wants to use the ESAPI library for their own purposes with the default ESAPI config impl to do so either declaratively or programatically.  And also seems a little clearer - the behavior of their initialize() and use of reflection, etc isn't well-documented that I can find.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the commits mailing list