[JIRA] Created: (JOST-189) RoleDescriptorImpl isValid check enforces that validUntil date is before now, instead of in the future

[philvarner@idp.protectnetwork.org (JIRA)]

RoleDescriptorImpl isValid check enforces that validUntil date is before now, instead of in the future
------------------------------------------------------------------------------------------------------

                 Key: JOST-189
                 URL: https://issues.shibboleth.net/jira/browse/JOST-189
             Project: OpenSAML 2 - Java
          Issue Type: Bug
            Reporter: philvarner at idp.protectnetwork.org
            Assignee: Chad La Joie


The relevant code is from RoleDescriptorImpl:

    public boolean isValid() {
        if (validUntil != null) {
            return validUntil.isBeforeNow();
        } else {
            return true;
        }
    }

which checks that that the date is before now.

EntityDescriptorImpl and EntitiesDescriptorImpl have the correct check:

    public boolean isValid() {
        if (null == validUntil) {
            return true;
        }

        DateTime now = new DateTime();
        return now.isBefore(validUntil);
    }


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira