[java-identity-provider COMMIT] in /trunk: idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAc...

[noreply at shibboleth.net]

Author: lajoie
Date: Mon May  7 12:55:31 2012
New Revision: 4187

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4187&view=rev
Log:
Minor code cleanup
Add some constraint annotations

Modified:
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMessageLifetime.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMessageReplay.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckSpringRequestContext.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/DecodeMessage.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/FilterAttributes.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContext.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/ResolveAttributes.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/SchemaValidateXmlMessage.java

Modified: trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java?rev=4187&r1=4186&r2=4187&view=diff
==============================================================================
--- trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java (original)
+++ trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java Mon May  7 12:55:31 2012
@@ -62,26 +62,28 @@
     /** Class logger. */
     private final Logger log = LoggerFactory.getLogger(AbstractProfileAction.class);
 
-    /**
-     * Strategy used to lookup the {@link HttpServletRequest} from a given WebFlow {@link RequestContext}. Default
-     * implementation is {@link WebflowRequestContextHttpServletRequestLookup}
-     */
+    /** Strategy used to lookup the {@link HttpServletRequest} from a given WebFlow {@link RequestContext}. */
     private Function<RequestContext, HttpServletRequest> httpRequestLookupStrategy;
 
-    /**
-     * Strategy used to lookup the {@link HttpServletResponse} from a given WebFlow {@link RequestContext}. Default
-     * implementation is {@link WebflowRequestContextHttpServletResponseLookup}
-     */
+    /** Strategy used to lookup the {@link HttpServletResponse} from a given WebFlow {@link RequestContext}. */
     private Function<RequestContext, HttpServletResponse> httpResponseLookupStrategy;
 
-    /**
-     * Strategy used to lookup the {@link ProfileRequestContext} from a given WebFlow {@link RequestContext}. Default
-     * implementation is {@link WebflowRequestContextProfileRequestContextLookup}
-     */
+    /** Strategy used to lookup the {@link ProfileRequestContext} from a given WebFlow {@link RequestContext}. */
     private Function<RequestContext, ProfileRequestContext> profileContextLookupStrategy;
 
-    /** Constructor. */
+    /**
+     * Constructor.
+     * 
+     * Initializes the ID of this action to the class name. Initializes {@link #httpRequestLookupStrategy} to
+     * {@link WebflowRequestContextHttpServletRequestLookup}. Initializes {@link #httpResponseLookupStrategy} to
+     * {@link WebflowRequestContextHttpServletResponseLookup}. Initializes {@link #profileContextLookupStrategy} to
+     * {@link WebflowRequestContextProfileRequestContextLookup}.
+     */
     public AbstractProfileAction() {
+        super();
+
+        setId(getClass().getName());
+
         httpRequestLookupStrategy = new WebflowRequestContextHttpServletRequestLookup();
         httpResponseLookupStrategy = new WebflowRequestContextHttpServletResponseLookup();
         profileContextLookupStrategy = new WebflowRequestContextProfileRequestContextLookup();

Modified: trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java?rev=4187&r1=4186&r2=4187&view=diff
==============================================================================
--- trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java (original)
+++ trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java Mon May  7 12:55:31 2012
@@ -44,14 +44,17 @@
      */
     private Function<MessageContext, BasicMessageMetadataContext> messageMetadataContextLookupStrategy;
 
-    /** Constructor. The ID of this component is set to the name of this class. */
+    /**
+     * Constructor.
+     * 
+     * Initializes {@link #messageMetadataContextLookupStrategy} to {@link ChildContextLookup}.
+     */
     public CheckMandatoryIssuer() {
         super();
 

[... 298 lines stripped ...]