[JIRA] Created: (SIDP-547) VelocityEngine initialization was not effectively using UTF-8 input and output encoding

Brent Putman (JIRA) noreply at shibboleth.net
Wed May 2 22:47:03 BST 2012


VelocityEngine initialization was not effectively using UTF-8 input and output encoding
---------------------------------------------------------------------------------------

                 Key: SIDP-547
                 URL: https://issues.shibboleth.net/jira/browse/SIDP-547
             Project: Shibboleth IdP 2 - Java
          Issue Type: Bug
          Components: Attribute Resolution, SAML 1, SAML 2
    Affects Versions: 2.3.6
            Reporter: Brent Putman
            Assignee: Chad La Joie
            Priority: Minor


Related to JOST-188, the OpenSAML DefaultBootstrap settings for input.encoding and output.encoding were not being used in the VelocityEngine instance being injected by Spring via internal.xml.  The intent (via OpenSAML) was for UTF-8 encoding, but instead it is likely using the internal Velocity default of ISO-8859-1.

We should probably move this setting to UTF-8 into internal.xml.  The SAML encoders work fine with either apparently, but we should examine whether moving from ISO-8859-1 to UTF-8 will have any adverse effects on other IdP components that use Velocity, such as the TemplateEngine used in the data connectors, and the Template attribute definition.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the commits mailing list