[utilities COMMIT] /java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/UriSupport.java

[noreply at shibboleth.net]

Author: putmanb
Date: Tue Mar 27 21:14:32 2012
New Revision: 261

URL: http://svn.shibboleth.net/view/utilities?rev=261&view=rev
Log:
When parsing a query string and it is empty, don't return a Collections.emptyList(), because the return value may be mutated by the caller.  Instead return a LazyList.

Modified:
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/UriSupport.java

Modified: java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/UriSupport.java
URL: http://svn.shibboleth.net/view/utilities/java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/UriSupport.java?rev=261&r1=260&r2=261&view=diff
==============================================================================
--- java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/UriSupport.java (original)
+++ java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/UriSupport.java Tue Mar 27 21:14:32 2012
@@ -26,6 +26,7 @@
 import java.util.Collections;
 import java.util.List;
 
+import net.shibboleth.utilities.java.support.collection.LazyList;
 import net.shibboleth.utilities.java.support.collection.Pair;
 import net.shibboleth.utilities.java.support.primitive.StringSupport;
 
@@ -235,7 +236,7 @@
     public static List<Pair<String, String>> parseQueryString(final String queryString) {
         final String trimmedQuery = trimOrNullQuery(queryString);
         if (trimmedQuery == null) {
-            return Collections.emptyList();
+            return new LazyList<Pair<String,String>>();
         }
 
         final ArrayList<Pair<String, String>> queryParams = new ArrayList<Pair<String, String>>();