[java-identity-provider COMMIT] in /trunk/idp-attribute-api/src: main/java/net/shibboleth/idp/attribute/ByteAttribute...

[noreply at shibboleth.net]

Author: rdw
Date: Mon Mar 26 15:02:31 2012
New Revision: 4139

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4139&view=rev
Log:
Better tests and consequent fix for ByteAttributeValue

Added:
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ByteAttributeValueTest.java   (with props)
Modified:
    trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java

Modified: trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java?rev=4139&r1=4138&r2=4139&view=diff
==============================================================================
--- trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java (original)
+++ trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java Mon Mar 26 15:02:31 2012
@@ -82,7 +82,7 @@
         }
 
         ByteAttributeValue other = (ByteAttributeValue) obj;
-        return Objects.equal(value, other.value);
+        return Arrays.equals(other.value, value);
     }
 
     /** {@inheritDoc} */

Modified: trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java?rev=4139&r1=4138&r2=4139&view=diff
==============================================================================
--- trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java (original)
+++ trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java Mon Mar 26 15:02:31 2012
@@ -70,7 +70,7 @@
         Assert.assertEquals(value1.hashCode(), value2.hashCode());
 
         Assert.assertFalse(value1.equals(value3));
-        Assert.assertFalse(value1.equals(new Integer(2)));
+        Assert.assertFalse(value1.equals(this));
         Assert.assertFalse(value1.equals(null));
         Assert.assertFalse(value3.equals(value1));
 

Modified: trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java?rev=4139&r1=4138&r2=4139&view=diff
==============================================================================
--- trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java (original)
+++ trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java Mon Mar 26 15:02:31 2012
@@ -58,7 +58,7 @@
 
         Assert.assertFalse(value1.equals(value3));
         Assert.assertFalse(value1.equals(null));
-        Assert.assertFalse(value1.equals(new Integer(2)));
+        Assert.assertFalse(value1.equals(this));
         Assert.assertFalse(value3.equals(value1));
 
         Assert.assertFalse(value2.equals(value3));