[JIRA] Created: (SDSJ-108) Refactoring of Config settings inverted the setting of showUnusableIdPs

Rod Widdowson (JIRA) noreply at shibboleth.net
Tue Mar 20 17:41:16 GMT 2012


Refactoring of Config settings inverted the setting of showUnusableIdPs
-----------------------------------------------------------------------

                 Key: SDSJ-108
                 URL: https://issues.shibboleth.net/jira/browse/SDSJ-108
             Project: Shibboleth Discovery Service - Java
          Issue Type: Bug
    Affects Versions: 1.2
            Reporter: Rod Widdowson
            Assignee: Chad La Joie
             Fix For: 1.2.1


In the old code we went

lookupSp = !Boolean.valueOf(attribute).booleanValue();

In the new code we go 

lookupSp = lookupElement(config,"showUnusableIdPs", defaultValue.lookupSp);

When it should be

lookupSp = !lookupElement(config,"showUnusableIdPs", !defaultValue.lookupSp);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the commits mailing list