[JIRA] Closed: (SIDP-543) No support for data URI in combination with MDUI Logo but for mailto?

[Rod Widdowson (JIRA)]

     [ https://issues.shibboleth.net/jira/browse/SIDP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rod Widdowson closed SIDP-543.
------------------------------


> No support for data URI in combination with MDUI Logo but for mailto?
> ---------------------------------------------------------------------
>
>                 Key: SIDP-543
>                 URL: https://issues.shibboleth.net/jira/browse/SIDP-543
>             Project: Shibboleth IdP 2 - Java
>          Issue Type: Improvement
>            Reporter: Lukas Haemmerle
>            Assignee: Rod Widdowson
>            Priority: Minor
>             Fix For: 2.3.7
>
>          Time Spent: 2 hours
>  Remaining Estimate: 0 minutes
>
> We are considering to embed MDUI logos in metadata using the data URI. When testing, we noticed that SP and EDS seem to handle embedded logos just fine. However, the IdP won't display the logos on the login.jsp page.
> The log says:
> {noformat}
> WARN [edu.internet2.middleware.shibboleth.idp.ui.ServiceLogoTag:183] - The logo URL data:image/gif;base64,R0lGOD....AAAOw== contained an invalid scheme
> {noformat}
> The reason is the ServiceLogo class, more specific the code:
> {code:java}
>             if (!"http".equals(scheme) && !"https".equals(scheme) && !"mailto".equals(scheme)) {
>                 log.warn("The logo URL " + url + " contained an invalid scheme");
>                 return null;
>             }
> {code}
> Now the questions are whether the scheme "data:" was excluded on purpose (if so, why?) and why the "mailto:" scheme is allowed on the other hand? The mailto doesn't seem to make sense in an image src attribute.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira