[JIRA] Created: (SDSJ-105) wayf.jsp fails to properly escape mdui:DisplayName, causing javascript error and Suggest.js to fail to work

[cjh@psu.edu (JIRA)]

wayf.jsp fails to properly escape mdui:DisplayName, causing javascript error and Suggest.js to fail to work
-----------------------------------------------------------------------------------------------------------

                 Key: SDSJ-105
                 URL: https://issues.shibboleth.net/jira/browse/SDSJ-105
             Project: Shibboleth Discovery Service - Java
          Issue Type: Bug
    Affects Versions: 1.1.3
         Environment: shibboleth-discovery-service 1.1.3
            Reporter: cjh at psu.edu
            Assignee: Chad La Joie


Line 562 and 637 of wayf.jsp fail to escape mdui:DisplayName causing javascript to error. 

This presented itself as a problem when the 'Ohio Technology Consortium ("OH-TECH")' was added to the metadata as the double quote as interpreted by javascript as a string terminator.

          <mdui:DisplayName xml:lang="en">Ohio Technology Consortium ("OH-TECH")</mdui:DisplayName>


The two Javascript errors follow:

Error: missing ) after argument list
Source File: https://confluence.et-test.psu.edu/discovery/WAYF?entityID=https%3A%2F%2Fconfluence.et-test.psu.edu%2Fshibboleth&return=https%3A%2F%2Fconfluence.et-test.psu.edu%2FShibboleth.sso%2FLogin%3FSAMLDS%3D1%26target%3Dcookie%253Ac1c23b83
Line: 1499, Column: 58
Source Code:
          opt = new Option ("Ohio Technology Consortium ("OH-TECH")"); 


"Error: missing ] after element list
Source File: https://confluence.et-test.psu.edu/discovery/WAYF?entityID=https%3A%2F%2Fconfluence.et-test.psu.edu%2Fshibboleth&return=https%3A%2F%2Fconfluence.et-test.psu.edu%2FShibboleth.sso%2FLogin%3FSAMLDS%3D1%26target%3Dcookie%253Ac1c23b83
Line: 3269, Column: 36
Source Code:
     ["Ohio Technology Consortium ("OH-TECH")","
------------

This is also affecting the DS at discovery.shibboleth.net. 

Error: missing ] after element list
Source File: https://discovery.shibboleth.net/WAYF?entityID=https%3A%2F%2Fissues.shibboleth.net%2Fshibboleth&return=https%3A%2F%2Fissues.shibboleth.net%2Fjira%2FShibboleth.sso%2FLogin%3FSAMLDS%3D1%26target%3Dss%253Amem%253A34ac60553824bda89ec1c4bade43aabedd6dbda0
Line: 3884, Column: 33
Source Code:
  ["Ohio Technology Consortium ("OH-TECH")","https://idp.oar.net/idp/shibboleth"], 




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira