[java-identity-provider COMMIT] in /trunk: idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAc...

[noreply at shibboleth.net]

Author: lajoie
Date: Sun Jul 15 16:45:06 2012
New Revision: 4202

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4202&view=rev
Log:
refactor some Event IDs
Remove some exceptions
Do some code cleanup

Modified:
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/EventIds.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/InvalidInboundMessageContextException.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/InvalidInboundMessageException.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/InvalidOutboundMessageContextException.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/InvalidOutboundMessageException.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/InvalidProfileRequestContextStateException.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/InvalidSubcontextException.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMessageLifetime.java
    trunk/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/SetProfileIdTest.java
    trunk/idp-saml-api/src/test/java/net/shibboleth/idp/saml/profile/saml1/Saml1ActionSupportTest.java
    trunk/idp-saml-api/src/test/java/net/shibboleth/idp/saml/profile/saml2/Saml2ActionSupportTest.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/AddSamlMetadataToMessageContext.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddAttributeStatementToAssertion.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/AddAttributeStatementToAssertion.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/AddAudienceRestrictionToAssertions.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/AddNotBeforeConditionToAssertions.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/AddNotOnOrAfterConditionToAssertions.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/AddOneTimeUseConditionToAssertions.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/AddResponseShell.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/CheckRequestVersion.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml1/CheckRequestVersionTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml2/CheckRequestVersionTest.java

Modified: trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java?rev=4202&r1=4201&r2=4202&view=diff
==============================================================================
--- trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java (original)
+++ trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractProfileAction.java Sun Jul 15 16:45:06 2012
@@ -177,7 +177,7 @@
                 profileContextLookupStrategy.apply(springRequestContext);
         if (profileRequestContext == null) {
             log.error("Action {}: IdP profile request context is not available", getId());
-            throw new InvalidProfileRequestContextStateException("IdP profile request context is not available");
+            return ActionSupport.buildEvent(this, EventIds.NO_PROFILE_CTX);
         }
 
         profileRequestContext.setHttpRequest(httpRequest);

Modified: trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/EventIds.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/EventIds.java?rev=4202&r1=4201&r2=4202&view=diff
==============================================================================
--- trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/EventIds.java (original)
+++ trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/EventIds.java Sun Jul 15 16:45:06 2012
@@ -20,12 +20,24 @@
 /** Constants to use for {@link org.springframework.webflow.execution.Event} IDs. */
 public final class EventIds {
 
+    /** Incoming request did not contains a {@link ProfileRequestContext}. */
+    public static final String NO_PROFILE_CTX = "NoProfileCtx";
+
+    /** ID of the event returned if an expected {@link org.opensaml.messaging.context.MessageContext} is missing. */
+    public static final String NO_MSG_CTX = "NoMessageContext";
+
+    /**
+     * ID of the event returned if a {@link org.opensaml.messaging.context.MessageContext} does not contain a necessary
+     * {@link org.opensaml.messaging.context.BasicMessageMetadataContext}.
+     */
+    public static final String NO_MSG_MD = "NoMessageMetadata";
+
     /**

[... 1240 lines stripped ...]