[utilities COMMIT] /java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/xml/NamespaceSupport.java

noreply at shibboleth.net noreply at shibboleth.net
Tue Jan 31 14:27:00 GMT 2012


Author: rdw
Date: Tue Jan 31 14:27:00 2012
New Revision: 226

URL: http://svn.shibboleth.net/view/utilities?rev=226&view=rev
Log:
Remove now redundant (and possibly buggy) code as well as a comment which my previous checkin gratuitously made wrong.  

Modified:
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/xml/NamespaceSupport.java

Modified: java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/xml/NamespaceSupport.java
URL: http://svn.shibboleth.net/view/utilities/java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/xml/NamespaceSupport.java?rev=226&r1=225&r2=226&view=diff
==============================================================================
--- java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/xml/NamespaceSupport.java (original)
+++ java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/xml/NamespaceSupport.java Tue Jan 31 14:27:00 2012
@@ -51,11 +51,6 @@
 
         final String nsURI = StringSupport.trimOrNull(namespaceURI);
         final String nsPrefix = StringSupport.trimOrNull(prefix);
-
-        // This results in xmlns="" being omitted, which seems wrong.
-        if (nsURI == null && nsPrefix == null) {
-            return;
-        }
 
         String attributeName;
         if (nsPrefix == null) {
@@ -189,7 +184,6 @@
                 attr = map.item(i);
                 if (Objects.equal(attr.getNamespaceURI(), XmlConstants.XMLNS_NS)) {
                     // DOM Level 2 nodes
-                    String s = attr.getNodeName();
                     if ((Objects.equal(attr.getPrefix(), XmlConstants.XMLNS_PREFIX))
                             && Objects.equal(attr.getNodeValue(), namespaceURI)) {
 



More information about the commits mailing list