[JIRA] Commented: (SC-170) Expose LDAP pool blockWaitTime on VT pool strategy via connector config

Chad La Joie (JIRA) noreply at shibboleth.net
Thu Feb 9 19:11:37 GMT 2012


    [ https://issues.shibboleth.net/jira/browse/SC-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810#comment-13810 ] 

Chad La Joie commented on SC-170:
---------------------------------

validate just isn't the right place for that call.  In v3 here is an explicit initialize() call for this reason.

Just so I'm clear, the issue really is that during pool initialization if the pool is actually pooling connection, the IdP fails immediately because no connection can be gotten.  If it's a no-op pool impl, it doesn't fail until the resolver validates and tries to grab a connection from the pool.  Is that correct?

> Expose LDAP pool blockWaitTime on VT pool strategy via connector config
> -----------------------------------------------------------------------
>
>                 Key: SC-170
>                 URL: https://issues.shibboleth.net/jira/browse/SC-170
>             Project: Shibboleth Common - Java
>          Issue Type: Improvement
>          Components: Attribute Authority
>    Affects Versions: 1.3.4
>            Reporter: Scott Cantor
>            Assignee: Daniel W Fisher
>         Attachments: vt-ldap-3.3.5-SNAPSHOT-dist.tar.gz
>
>
> If you have a pool configured in the LDAP connector, and the LDAP server doesn't respond or there's a trust-related error preventing connections, the IdP fails to start up but also hangs inside the pool init method waiting for at least one connection to come back. There's a blockWaitTime setting, but it apparently defaults to indefinite wait, and it isn't exposed in our config.
> We should at least expose it via the Pool config schema that wraps the internal VT pool, and use a better default, or perhaps use different defaults based on whether a hard or soft pool is used?
> Daniel also mentioned changing the VT library to throw an exception out if the minimum number of connections can't be set up in the pool.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the commits mailing list