[JIRA] Closed: (IDP-151) Convert Attribute Filter Impl code to use Java-support and Google Guava

[Chad La Joie (JIRA)]

     [ https://issues.shibboleth.net/jira/browse/IDP-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chad La Joie closed IDP-151.
----------------------------

    Resolution: Completed

Yep, that all looks fine.  Some of the items I listed just got subsumed by the refactoring I was doing.

> Convert Attribute Filter Impl code to use Java-support and Google Guava
> -----------------------------------------------------------------------
>
>                 Key: IDP-151
>                 URL: https://issues.shibboleth.net/jira/browse/IDP-151
>             Project: Identity Provider
>          Issue Type: Task
>          Components: Attribute Filter
>            Reporter: Chad La Joie
>            Assignee: Chad La Joie
>   Original Estimate: 4 hours, 30 minutes
>          Time Spent: 3 hours, 20 minutes
>  Remaining Estimate: 1 hour, 10 minutes
>
> Review the attribute filter impl code for the following items:
> - ensure all initializable and destructable components properly check that they are initialized and not destroyed before doing in their getMatchingValue functions
> - convert Base*Compare classes to use Guava provided Predicates
> - ensure all predicates and matchers have hashCode, equals, and toString methods
> - ensure unit test class names are Test* not *Test
> - ensure that unit tests cover cases where: input is null, object use is attempted when it is not initialized or is destroyed 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira