[JIRA] Commented: (IDP-151) Convert Attribute Filter Impl code to use Java-support and Google Guava

[Rod Widdowson (JIRA)]

    [ https://issues.shibboleth.net/jira/browse/IDP-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798#comment-13798 ] 

Rod Widdowson commented on IDP-151:
-----------------------------------

> ensure all initializable and destructable components properly check that they are initialized and not destroyed before doing in their getMatchingValue functions

Checkin 4114

> convert Base*Compare classes to use Guava provided Predicates

This appears to be complete.  I'll be reassigning this to Chad to confirm.

> ensure all predicates and matchers have hashCode, equals, and toString methods
Checked.

> ensure unit test class names are Test* not *Test

I think this is wrong.  All test classes currently *end* in Test as per the rest of the system.

> ensure that unit tests cover cases where: input is null, object use is attempted when it is not initialized or is destroyed

Checkin 4114 

> Convert Attribute Filter Impl code to use Java-support and Google Guava
> -----------------------------------------------------------------------
>
>                 Key: IDP-151
>                 URL: https://issues.shibboleth.net/jira/browse/IDP-151
>             Project: Identity Provider
>          Issue Type: Task
>          Components: Attribute Filter
>            Reporter: Chad La Joie
>            Assignee: Rod Widdowson
>   Original Estimate: 4 hours, 30 minutes
>  Remaining Estimate: 4 hours, 30 minutes
>
> Review the attribute filter impl code for the following items:
> - ensure all initializable and destructable components properly check that they are initialized and not destroyed before doing in their getMatchingValue functions
> - convert Base*Compare classes to use Guava provided Predicates
> - ensure all predicates and matchers have hashCode, equals, and toString methods
> - ensure unit test class names are Test* not *Test
> - ensure that unit tests cover cases where: input is null, object use is attempted when it is not initialized or is destroyed 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira