[utilities COMMIT] in /java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component: AbstractDest...

[noreply at shibboleth.net]

Author: scantor
Date: Fri Dec 14 21:11:16 2012
New Revision: 307

URL: http://svn.shibboleth.net/view/utilities?rev=307&view=rev
Log:
Checkstyle and doc fixes.

Modified:
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableIdentifiableInitializableComponent.java
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableInitializableComponent.java
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/ComponentInitializationException.java
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/ComponentSupport.java
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/DestructableComponent.java
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/InitializableComponent.java
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/ValidatableComponent.java

Modified: java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableIdentifiableInitializableComponent.java
URL: http://svn.shibboleth.net/view/utilities/java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableIdentifiableInitializableComponent.java?rev=307&r1=306&r2=307&view=diff
==============================================================================
--- java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableIdentifiableInitializableComponent.java (original)
+++ java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableIdentifiableInitializableComponent.java Fri Dec 14 21:11:16 2012
@@ -39,7 +39,7 @@
     }
 
     /**
-     * Sets the ID of this component.
+     * Sets the ID of this component. The component must not be initialized or destroyed.
      * 
      * @param componentId ID of the component
      */

Modified: java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableInitializableComponent.java
URL: http://svn.shibboleth.net/view/utilities/java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableInitializableComponent.java?rev=307&r1=306&r2=307&view=diff
==============================================================================
--- java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableInitializableComponent.java (original)
+++ java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractDestructableInitializableComponent.java Fri Dec 14 21:11:16 2012
@@ -58,7 +58,10 @@
         isInitialized = true;
     }
 
-    /** Performs component specific destruction logic. Default implementation of this method is a no-op. */
+    /**
+     * Performs component specific destruction logic. This method is executed within the lock on the object being
+     * destroyed. The default implementation of this method is a no-op.
+     */
     protected void doDestroy() {
 
     }

Modified: java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java
URL: http://svn.shibboleth.net/view/utilities/java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java?rev=307&r1=306&r2=307&view=diff
==============================================================================
--- java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java (original)
+++ java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java Fri Dec 14 21:11:16 2012
@@ -41,14 +41,12 @@
     }
 
     /**
-     * Sets the ID of this component.
+     * Sets the ID of this component. The component must not yet be initialized.
      * 
      * @param componentId ID of the component
      */
     protected synchronized void setId(@Nonnull @NotEmpty final String componentId) {
-        if (isInitialized()) {
-            return;
-        }
+        ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
 
         id = Constraint.isNotNull(StringSupport.trimOrNull(componentId), "Component ID can not be null or empty");
     }

Modified: java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/ComponentInitializationException.java
URL: http://svn.shibboleth.net/view/utilities/java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/ComponentInitializationException.java?rev=307&r1=306&r2=307&view=diff
==============================================================================

[... 128 lines stripped ...]