[JIRA] Closed: (JOST-194) org.opensaml.ESAPISecurityConfig should use singleton pattern like the default ESAPI reference class

[Brent Putman (JIRA)]

     [ https://issues.shibboleth.net/jira/browse/JOST-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brent Putman closed JOST-194.
-----------------------------


> org.opensaml.ESAPISecurityConfig should use singleton pattern like the default ESAPI reference class
> ----------------------------------------------------------------------------------------------------
>
>                 Key: JOST-194
>                 URL: https://issues.shibboleth.net/jira/browse/JOST-194
>             Project: OpenSAML 2 - Java
>          Issue Type: Improvement
>    Affects Versions: 2.5.3
>            Reporter: Brent Putman
>            Assignee: Brent Putman
>            Priority: Minor
>             Fix For: 2.5.4
>
>   Original Estimate: 20 minutes
>          Time Spent: 20 minutes
>  Remaining Estimate: 0 minutes
>
> Our custom ESAPI SecurityConfiguration class impl doesn't implement the getInstance singleton pattern like the ESAPI reference impl (it's static so not on the interface and so was missed).  The ESAPI locator attempts to reflectively instantiate the config instance every time via an object factory, and so a new instance is created every time, unless it implements a static getInstance.  This is causing a lot of unnecessary object churn.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira