[JIRA] Commented: (JXT-88) AbstractXMLObject unnecessarily creates a new QName in getElementQName

anli.shundi@idp.protectnetwork.org (JIRA) noreply at shibboleth.net
Sat Aug 11 00:13:07 EDT 2012


    [ https://issues.shibboleth.net/jira/browse/JXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317#comment-14317 ] 

anli.shundi at idp.protectnetwork.org commented on JXT-88:
-------------------------------------------------------

Yes... but I didn't mean those.  Just opened JXT-89 for {{AbstractXMLObjectUnmarshaller.unmarshall(Element domElement)}}

> AbstractXMLObject unnecessarily creates a new QName in getElementQName
> ----------------------------------------------------------------------
>
>                 Key: JXT-88
>                 URL: https://issues.shibboleth.net/jira/browse/JXT-88
>             Project: XMLTooling - Java
>          Issue Type: Bug
>    Affects Versions: 1.3.4
>            Reporter: anli.shundi at idp.protectnetwork.org
>            Assignee: Brent Putman
>            Priority: Minor
>             Fix For: 1.3.5
>
>          Time Spent: 10 minutes
>  Remaining Estimate: 0 minutes
>
> Since QName is immutable the member should be instead returned.
> Talking about optimizations: it would be preferable to check isTraceEnabled before concatenating & passing arguments to trace.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the commits mailing list