[JIRA] Commented: (JOWS-37) FileBackedHttpResource does not properly read backup file, during initialization, if remote file is unreachable

[Brent Putman (JIRA)]

    [ https://issues.shibboleth.net/jira/browse/JOWS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315#comment-14315 ] 

Brent Putman commented on JOWS-37:
----------------------------------

The issue here is directly the behavior of the HttpResource exists() method, which is called by the resource watcher constructor. It reports true on a 200, false on successful receipt of any other status code, and throws otherwise (if there is an IOException).  Perhaps "not exists" should include certain classes of IO exceptions (like java.net.Socket- or ConnectException. Depends on what we want the "exists" semantic to be, e.g. in the face of invalid URL's as in the original issue.  Maybe a config flag should be here.

Alternatively, the FileBackedHttpResource exists() could be tweaked to swallow the thrown Exception, treating it as "Http resource does not exist", then falling back to evaling the backing file.

> FileBackedHttpResource does not properly read backup file, during initialization, if remote file is unreachable
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: JOWS-37
>                 URL: https://issues.shibboleth.net/jira/browse/JOWS-37
>             Project: OpenWS - Java
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 1.4.4
>            Reporter: Chad La Joie
>            Assignee: Chad La Joie
>            Priority: Minor
>
> The FileBackedHttpResource does not read, and return, the backup file if the remote file can not be read during installation.  This may be desired behavior in some cases but may not be in others.  Probably should have a flag to control this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira