[JIRA] Resolved: (OSJ-15) InitializationService.initialize() should take close to zero time for mutiple callers (shouldn't it?)

[Rod Widdowson (JIRA)]

     [ https://issues.shibboleth.net/jira/browse/OSJ-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rod Widdowson resolved OSJ-15.
------------------------------

    Resolution: Invalid

I'm going to resolve this.  You can close if you agree.

I'll make the changes you suggest.

As for whether init should be re-entrant I suggest we take this out to shib-dev.  All the components I have authored and tested expect to be called at initialize multiple times.  My motivation is that if you have cascading initialize you may loose track of what has been initialized and you certainly will if the initialize tree stops being a digraph.

So (obviously) I am a believer in this.  But it needs wider airing?

> InitializationService.initialize() should take close to zero time for mutiple callers (shouldn't it?)
> -----------------------------------------------------------------------------------------------------
>
>                 Key: OSJ-15
>                 URL: https://issues.shibboleth.net/jira/browse/OSJ-15
>             Project: OpenSAML - Java
>          Issue Type: Improvement
>         Environment: Windoze 7 x64 running from an SSD drive. Eclipse, Java6.22 (64 bit).
>            Reporter: Rod Widdowson
>            Assignee: Brent Putman
>            Priority: Trivial
>
> This is a nice to have, no more, but I think will help the whole project going forward.  If it's PEBKAC or not fixable, then that's fine too.
> I have been doing some IDP testing which depends on OpenSAML and the general mechanism used is to say:
>     @BeforeSuite() public void initOpenSAML() throws InitializationException {
>         InitializationService.initialize();
>         // Other per module set up
>     }
> In each test module.  This means that running an individual test module can take a bit of time but 10 seconds isn't the end of the world.
> I was however surprised that the amount of time taken during initialization goes up as I do more tests since I had expected that the Initialize bit would take zero time the second and third time through.
> So I did a pretty non scientific experiment and called InitializationService.initialize() 11 times in a loop.  
> The first call takes around 12 seconds
> The second and third about 1 second
> And form then on each call takes about 0.4 to 0.6 seconds.
> Like I say this is no big deal, but by the time we are running a thousand tests it is going to suck up a lot of cycles...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira