[java-centralized-discovery COMMIT] /branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/wayf/plugins/pr...

noreply at shibboleth.net noreply at shibboleth.net
Tue Sep 20 16:12:16 BST 2011


Author: rdw
Date: Tue Sep 20 16:12:16 2011
New Revision: 2197

URL: http://svn.shibboleth.net/view/java-centralized-discovery?rev=2197&view=rev
Log:
https://issues.shibboleth.net/jira/browse/SDSJ-90

Further tested showed that some code tidy had exposed a day-1 demorganization bug in the cookie code.  We now only set the domain if it is nonnull and nonempty

Modified:
    branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/wayf/plugins/provider/SamlCookiePlugin.java

Modified: branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/wayf/plugins/provider/SamlCookiePlugin.java
URL: http://svn.shibboleth.net/view/java-centralized-discovery/branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/wayf/plugins/provider/SamlCookiePlugin.java?rev=2197&r1=2196&r2=2197&view=diff
==============================================================================
--- branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/wayf/plugins/provider/SamlCookiePlugin.java (original)
+++ branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/wayf/plugins/provider/SamlCookiePlugin.java Tue Sep 20 16:12:16 2011
@@ -484,7 +484,7 @@
 
             cookie.setMaxAge(expiration);
 
-            if (domain != null && domain.isEmpty()) {
+            if (domain != null && !domain.isEmpty()) {
                 cookie.setDomain(domain);
             }
             res.addCookie(cookie);



More information about the commits mailing list