[java-identity-provider COMMIT] in /trunk: idp-profile-api/src/main/java/net/shibboleth/idp/profile/ActionSupport.jav...

[noreply at shibboleth.net]

Author: lajoie
Date: Thu Sep  1 14:02:26 2011
New Revision: 4047

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4047&view=rev
Log:
Add helper method for building Proceed actions and use it

Modified:
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ActionSupport.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMessageLifetime.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMessageReplay.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/DecodeMessage.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/FilterAttributes.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContext.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/ResolveAttributes.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/AbstractAddSamlMetadataToMessageContext.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/AddRelyingPartyConfigurationToProfileRequestContext.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddAuthenticationStatementToAssertion.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddDoNotCacheConditionToAssertions.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddInResponseToToResponse.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddNotBeforeConditionToAssertions.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddResponseShell.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/CheckRequestVersion.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/AddResponseShell.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/CheckRequestVersion.java

Modified: trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ActionSupport.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ActionSupport.java?rev=4047&r1=4046&r2=4047&view=diff
==============================================================================
--- trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ActionSupport.java (original)
+++ trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ActionSupport.java Thu Sep  1 14:02:26 2011
@@ -35,15 +35,9 @@
 
     /**
      * ID of an Event indicating that the action completed successfully and processing should move on to the next
-     * action.
+     * step.
      */
     public static final String PROCEED_EVENT_ID = "proceed";
-
-    /**
-     * ID of an Event indicating that the action completed successfully and that the profile request processing is
-     * complete and a successful message should be sent back to the requester.
-     */
-    public static final String SUCCESS_EVENT_ID = "success";
 
     /**
      * ID of an Event indicating that the action encountered an error and that the profile request processing is
@@ -103,6 +97,17 @@
 
         return (HttpServletResponse) externalContext.getNativeResponse();
     }
+    
+    /**
+     * Builds a {@link #PROCEED_EVENT_ID} event with no related attributes.
+     * 
+     * @param source the source of the event
+     * 
+     * @return the proceed event
+     */
+    public static Event buildProceedEvent(IdentifiedComponent source){
+        return buildEvent(source, PROCEED_EVENT_ID, null);
+    }
 
     /**
      * Builds an event, to be returned by the given component.

Modified: trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java?rev=4047&r1=4046&r2=4047&view=diff
==============================================================================
--- trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java (original)
+++ trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java Thu Sep  1 14:02:26 2011
@@ -48,7 +48,7 @@
                     "Basic message metadata subcontext does not a message issuer");
         }
 
-        return ActionSupport.buildEvent(this, ActionSupport.PROCEED_EVENT_ID, null);
+        return ActionSupport.buildProceedEvent(this);
     }
 
     /** A profile processing exception that occurs when the inbound message has no identified message issuer. */

Modified: trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMessageLifetime.java

[... 362 lines stripped ...]