[JIRA] Created: (JOST-174) ChainingMetadataProvider calls clear() on unmodifiable list

[philvarner@idp.protectnetwork.org (JIRA)]

ChainingMetadataProvider calls clear() on unmodifiable list
-----------------------------------------------------------

                 Key: JOST-174
                 URL: https://issues.shibboleth.net/jira/browse/JOST-174
             Project: OpenSAML 2 - Java
          Issue Type: Bug
            Reporter: philvarner at idp.protectnetwork.org
            Assignee: Chad La Joie


in method setProviders, code is:

    if (newProviders == null || newProviders.isEmpty()) {
                providers.clear();
                return;
            }

but the default object for providers is:

        providers = Collections.EMPTY_LIST;

This was changed between 2.3.1 and 2.5.1. In 2.3.1, providers was an empty array list.  

I believe the fix to this is to replace providers.clear() with providers = Collections.EMPTY_LIST.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira