[JIRA] Closed: (SIDP-510) Error with stack trace when passive cannot be honored
Chad La Joie (JIRA)
noreply at shibboleth.net
Mon Oct 10 19:53:25 BST 2011
[ https://issues.shibboleth.net/jira/browse/SIDP-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chad La Joie closed SIDP-510.
-----------------------------
Resolution: Fixed
fixed in rev 3075
> Error with stack trace when passive cannot be honored
> -----------------------------------------------------
>
> Key: SIDP-510
> URL: https://issues.shibboleth.net/jira/browse/SIDP-510
> Project: Shibboleth IdP 2 - Java
> Issue Type: Bug
> Components: Authentication
> Affects Versions: 2.3.3
> Reporter: paulhethmon at idp.protectnetwork.org
> Assignee: Chad La Joie
> Priority: Minor
> Fix For: 2.3.4
>
>
> When using a custom login handler that supports passive authentication, when the passive request cannot be honored, the login handler must set an exception of type *PassiveAuthenticationException* and set it as an attribute of the session of type LoginHandler.AUTHENTICATION_EXCEPTION_KEY. This works to inform the relying party that passive cannot be honored.
> However, AuthenticationEngine.validateSuccessfulAuthentication will capture this and throw an exception logging it as an ERROR level in the process log.
> I would argue that while an error in the strict sense, it's not an unexpected error. It's a normal consequence of being unable to fulfill the passive requirements. I would think it should be logged at the WARN level as ERROR implies something is broke with your Shib setup that should be addressed quickly.
> Also, it seems that perhaps a more straight forward method for a Login Handler to convey this would be useful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the commits
mailing list