[JIRA] Resolved: (SDSJ-102) NPE when non SAML1 IdP selected in "WAYF" mode

Rod Widdowson (JIRA) noreply at shibboleth.net
Tue Nov 15 10:46:26 GMT 2011


     [ https://issues.shibboleth.net/jira/browse/SDSJ-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rod Widdowson resolved SDSJ-102.
--------------------------------

    Resolution: Fixed

checkin 2201

> NPE when non SAML1 IdP selected in "WAYF" mode
> ----------------------------------------------
>
>                 Key: SDSJ-102
>                 URL: https://issues.shibboleth.net/jira/browse/SDSJ-102
>             Project: Shibboleth Discovery Service - Java
>          Issue Type: Bug
>            Reporter: Rod Widdowson
>            Assignee: Rod Widdowson
>
> If an SP fires a WAYF request off to the DS.  The DS does two things wrong:
> 1) It displays IdPs which do not have a SSO binding of "urn:mace:shibboleth:1.0:profiles:AuthnRequest"
> 2) It then throws an NPE if you select it:
> java.lang.NullPointerException
> 	edu.internet2.middleware.shibboleth.wayf.IdPSite.getAddressForWAYF(IdPSite.java:189)
> 	edu.internet2.middleware.shibboleth.wayf.DiscoveryServiceHandler.forwardRequest(DiscoveryServiceHandler.java:855)
> 	edu.internet2.middleware.shibboleth.wayf.DiscoveryServiceHandler.handleSelection(DiscoveryServiceHandler.java:386)
> 	edu.internet2.middleware.shibboleth.wayf.DiscoveryServiceHandler.doGet(DiscoveryServiceHandler.java:325)
> 	edu.internet2.middleware.shibboleth.wayf.WayfService.doGet(WayfService.java:385)
> 	javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
> 	javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> We need to make the second stop happening.  But we must also fix the first - unlike the "showUnusableIdPs 9which is to do with colocation of SPs and IdPs in the same metadata source, this need not be controlled by configuration.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the commits mailing list