[JIRA] Created: (SDSJ-104) Cookie plugin. Ordering of multiple IdPs is wrong

Rod Widdowson (JIRA) noreply at shibboleth.net
Thu Dec 29 11:15:25 GMT 2011


Cookie plugin.  Ordering of multiple IdPs is wrong
--------------------------------------------------

                 Key: SDSJ-104
                 URL: https://issues.shibboleth.net/jira/browse/SDSJ-104
             Project: Shibboleth Discovery Service - Java
          Issue Type: Bug
            Reporter: Rod Widdowson
            Assignee: Rod Widdowson
            Priority: Minor


The specification states:

> The common domain cookie writing service (see below) SHOULD append 
> the identity provider's unique identifier to the list. If the identifier
> is already present in the list, it MAY remove and append it. The intent 
> is that the most recently established identity provider session is the 
> last one in the list.

But the code states:


  /**
   * Add the specified Shibboleth IdP Name to the cookie list or move to the front and then write it back.
   * 
   * We always add to the front (and remove from wherever it was)
   */

We need to fix this.  Note that this change will also affects the display code.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the commits mailing list