[JIRA] Created: (JOST-176) SubjectConfirmationUnmarshaller processChildElement misplaces KeyInfo

[frelibert@idp.protectnetwork.org (JIRA)]

SubjectConfirmationUnmarshaller processChildElement misplaces KeyInfo
---------------------------------------------------------------------

                 Key: JOST-176
                 URL: https://issues.shibboleth.net/jira/browse/JOST-176
             Project: OpenSAML 2 - Java
          Issue Type: Bug
          Components: SAML 1
    Affects Versions: 2.5.2
            Reporter: frelibert at idp.protectnetwork.org
            Assignee: Chad La Joie


ChildObjects of SAML 1.1 SubjectConfirmation can be:
- ConfirmationMethod
- SubjectConfirmationData
- KeyInfo

The SubjectConfirmationUnmarshaller does not verify if the incoming child is a KeyInfo.
If it is, it should be placed in KeyInfo.

There needs to be an extra if between the if/else structure below


public class SubjectConfirmationUnmarshaller extends AbstractSAMLObjectUnmarshaller {

    /** {@inheritDoc} */
    protected void processChildElement(XMLObject parentSAMLObject, XMLObject childSAMLObject)
            throws UnmarshallingException {

        SubjectConfirmation subjectConfirmation = (SubjectConfirmation) parentSAMLObject;

        if (childSAMLObject instanceof ConfirmationMethod) {
            subjectConfirmation.getConfirmationMethods().add((ConfirmationMethod) childSAMLObject);
        } else {
            subjectConfirmation.setSubjectConfirmationData(childSAMLObject);
        }
    }
}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira