[java-identity-provider COMMIT] in /trunk: idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractIdentityP...

[noreply at shibboleth.net]

Author: lajoie
Date: Tue Dec  6 19:42:00 2011
New Revision: 4083

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4083&view=rev
Log:
Remove unnecessary abstract Action class
Have actions throw Exception instead of trying to return Events with error data in it
Unit testing and bug fixes

Added:
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckSpringRequestContext.java   (with props)
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml1/CheckRequestVersionTest.java   (with props)
Removed:
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractInboundMessageSubcontextAction.java
Modified:
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractIdentityProviderAction.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ActionSupport.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuer.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMessageLifetime.java
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/CheckMessageReplay.java
    trunk/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/CheckMandatoryIssuerTest.java
    trunk/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContextTest.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/AddRelyingPartyConfigurationToProfileRequestContext.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/InitializeRelyingPartySubcontextBasedOnInboundMessageIssuer.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddAudienceRestrictionToAssertions.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddDoNotCacheConditionToAssertions.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddResponseShell.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/CheckRequestVersion.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/CheckRequestVersion.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/SamlActionTestingSupport.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml1/AddAudienceRestrictionToAssertionsTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml1/AddDoNotCacheConditionToAssertionsTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml1/AddNotBeforeConditionToAssertionsTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml1/AddNotOnOrAfterConditionToAssertionsTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml1/AddResponseShellTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml1/Saml1ActionTestingSupport.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/profile/saml2/CheckRequestVersionTest.java

Modified: trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractIdentityProviderAction.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractIdentityProviderAction.java?rev=4083&r1=4082&r2=4083&view=diff
==============================================================================
--- trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractIdentityProviderAction.java (original)
+++ trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/AbstractIdentityProviderAction.java Tue Dec  6 19:42:00 2011
@@ -28,10 +28,11 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.webflow.context.ExternalContext;
-import org.springframework.webflow.context.servlet.ServletExternalContext;
 import org.springframework.webflow.execution.Action;
 import org.springframework.webflow.execution.Event;
 import org.springframework.webflow.execution.RequestContext;
+
+//TODO perf metrics
 
 /**
  * Base class for IdP profile processing steps.
@@ -42,16 +43,11 @@
  * <li>ensure current {@link javax.servlet.http.HttpServletRequest} and {@link javax.servlet.http.HttpServletResponse}
  * is available on the {@link ProfileRequestContext}</li>
  * <li>tracking performance metrics for the action</li>
- * <li>providing convenience method for building the {@link Event} objects returned by this action</li>
- * <li>catching any {@link Throwable} thrown by {@link #doExecute(ProfileRequestContext)} and constructing an error
- * {@link Event} from it</li>
  * </ul>
  * 
  * @param <InboundMessageType> type of in-bound message
  * @param <OutboundMessageType> type of out-bound message
  */
-
-// TODO perf metrics
 @ThreadSafe
 public abstract class AbstractIdentityProviderAction<InboundMessageType, OutboundMessageType> extends
         AbstractIdentifiableInitializableComponent implements ValidatableComponent, Action {

[... 1778 lines stripped ...]