[JIRA] Closed: (IDP-98) Code reveiw comments on Attribute resolvers

[Rod Widdowson (JIRA)]

     [ https://issues.shibboleth.net/jira/browse/IDP-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rod Widdowson closed IDP-98.
----------------------------


> Code reveiw comments on Attribute resolvers
> -------------------------------------------
>
>                 Key: IDP-98
>                 URL: https://issues.shibboleth.net/jira/browse/IDP-98
>             Project: Identity Provider
>          Issue Type: Task
>          Components: Attribute Resolver
>            Reporter: Rod Widdowson
>            Assignee: Rod Widdowson
>            Priority: Minor
>             Fix For: 3.0.0
>
>   Original Estimate: 1 day
>  Remaining Estimate: 6 hours, 30 minutes
>
> Review as per https://lists.internet2.edu/sympa/arc/shibboleth-dev/2011-05/msg00078.html provides feedback for all the attribute resolvers (not just the two mentioned).  This case serves to act at the check in repository for them.
> Longly, go to the link about,. Briefly however
> 1) Better class comments
> 2) Wider spred use of final on local variables
> 3) Getters for all state.
> 4) Eschew setters; rather, pass in parameters but normalize where possible (StringSupport.* CollectionsSupport.*)
> 5) Just in time local variable declaration.
> 6) @ThreadSafe where possible (Note that the template cannot be thread safe since there are no suitable methods on a dependant velocity class 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira